Skip to content

test: skip test-snapshot-reproducible on all platforms#62808

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
panva:mark-snapshot-reproducible-flaky
Apr 19, 2026
Merged

test: skip test-snapshot-reproducible on all platforms#62808
nodejs-github-bot merged 2 commits intonodejs:mainfrom
panva:mark-snapshot-reproducible-flaky

Conversation

@panva
Copy link
Copy Markdown
Member

@panva panva commented Apr 18, 2026

#53579

@joyeecheung: I also ran into it in another unrelated PR, I think I might have some leads in how to fix it. For now I think we can just temporarily skip the test - the test is mostly FYI, we are not super serious about reproducibility of our builds, it's mostly a nice to have.

@joyeecheung: Yeah it's likely a V8 bug that's in my backlog or the way we configure V8 makes it somewhat prone to moving bits in paddings

@panva
test: mark test-snapshot-reproducible flaky
d899d21 
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
@panva panva requested a review from joyeecheung April 18, 2026 18:20
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 18, 2026
@panva panva added the fast-track PRs that do not need to wait for 72 hours to land. label Apr 18, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

Fast-track has been requested by @panva. Please 👍 to approve.

@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@aduh95
Copy link
Copy Markdown
Contributor

aduh95 commented Apr 18, 2026

Is it flaky though? Doesn't look like it. If the goal is to skip it on test-shared, let's do that explicitly by setting CI_SKIP_TESTS = [ "test-snapshot-reproducible" ] in shell.nix.

@panva
Copy link
Copy Markdown
Member Author

panva commented Apr 18, 2026

I don't think it's exclusive @aduh95 we've seen it in different contexts. I don't mind if it's skipped or marked as flaky.

panva
panva commented Apr 18, 2026
View reviewed changes
Comment thread test/parallel/parallel.status Outdated
@panva
apply suggestion
108b2c0 
Co-authored-by: Filip Skokan <panva.ip@gmail.com>
@panva panva added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 18, 2026
@joyeecheung
Copy link
Copy Markdown
Member

joyeecheung commented Apr 18, 2026

cc @sxa

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2026
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@aduh95 aduh95 changed the title test: mark test-snapshot-reproducible flaky test: skip test-snapshot-reproducible on all platforms Apr 18, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 18, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.68%. Comparing base (978a8c4) to head (108b2c0).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #62808      +/-   ##
==========================================
- Coverage   89.69%   89.68%   -0.01%     
==========================================
  Files         706      706              
  Lines      218222   218222              
  Branches    41766    41763       -3     
==========================================
- Hits       195726   195711      -15     
- Misses      14419    14432      +13     
- Partials     8077     8079       +2

see 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 18, 2026

CI: https://ci.nodejs.org/job/node-test-pull-request/72777/

@joyeecheung joyeecheung added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2026
@nodejs-github-bot nodejs-github-bot merged commit 58a8e1d into nodejs:main Apr 19, 2026
67 checks passed
@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

nodejs-github-bot commented Apr 19, 2026

Landed in 58a8e1d

@panva panva deleted the mark-snapshot-reproducible-flaky branch April 19, 2026 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lpinca lpinca lpinca approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

No one assigned

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. fast-track PRs that do not need to wait for 72 hours to land. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@panva @aduh95 @joyeecheung @nodejs-github-bot @lpinca